Skip to content

feat(fonts): granular preload #12572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sarah11918 merged 8 commits into from
Oct 23, 2025
Merged

feat(fonts): granular preload #12572

sarah11918 merged 8 commits into from
Oct 23, 2025

Conversation

@florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Oct 16, 2025

Description (required)

Documents the addition of granular preloads to the Font component

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 5.15. See astro PR #13826.

@netlify
Copy link

netlify bot commented Oct 16, 2025 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit e7d48ae
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/68f9cbb0b9383e00083af47f
😎 Deploy Preview https://deploy-preview-12572--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Oct 16, 2025 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/experimental-flags/fonts.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@florian-lefebvre florian-lefebvre mentioned this pull request Oct 16, 2025
Merged
3 tasks
ArmandPhilippot
ArmandPhilippot approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. I left a few nits: a typo and we usually describe the code snippet before, not after.

Edit: Ah, I just saw Matt comment about variable fonts. If there is a special behavior for them we might want to specify that here as well. But, otherwise, looks fine as it is!

@ArmandPhilippot ArmandPhilippot added this to the 5.15.0 milestone Oct 16, 2025
@ArmandPhilippot ArmandPhilippot added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Oct 16, 2025
@florian-lefebvre @ArmandPhilippot
Apply suggestions from code review
96bcde0 
Co-authored-by: Armand Philippot <[email protected]>
sarah11918
sarah11918 reviewed Oct 17, 2025
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments/questions from me!

ArmandPhilippot
ArmandPhilippot reviewed Oct 17, 2025
View reviewed changes
Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I left a suggestion to describe both cases in a single paragraph. See what you think of this and do not hesitate to edit to make it more accurate.

Edit: haha, Sarah was faster than me. 😅

@florian-lefebvre @sarah11918
Apply suggestions from code review
6af8db0 
Co-authored-by: Sarah Rainsberger <[email protected]>
sarah11918
sarah11918 approved these changes Oct 17, 2025
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

(Though, the deploy preview is slow and I haven't looked at the rendered page yet. This is all assuming there's nothing weird when I can check the page preview!)

ArmandPhilippot
ArmandPhilippot approved these changes Oct 17, 2025
View reviewed changes
Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me too (I've checked the preview)!

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Oct 17, 2025
yanthomasdev
yanthomasdev reviewed Oct 17, 2025
View reviewed changes
@sarah11918 sarah11918 changed the base branch from main to 5.15.0 October 23, 2025 06:32
@sarah11918 sarah11918 mentioned this pull request Oct 23, 2025
Merged
@sarah11918 sarah11918 merged commit b1d06ed into 5.15.0 Oct 23, 2025
6 checks passed
@sarah11918 sarah11918 deleted the feat/fonts-granular-preload branch October 23, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

@yanthomasdev yanthomasdev yanthomasdev left review comments

@ArmandPhilippot ArmandPhilippot ArmandPhilippot approved these changes

Assignees

No one assigned

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!

Projects

None yet

Milestone

5.15.0

Development

Successfully merging this pull request may close these issues.

5 participants

@florian-lefebvre @astrobot-houston @sarah11918 @ArmandPhilippot @yanthomasdev